[ 
https://issues.apache.org/jira/browse/FLINK-34388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819967#comment-17819967
 ] 

Ferenc Csaky commented on FLINK-34388:
--------------------------------------

Thank you [~Yu Chen] for the thorough testing!

{quote}By the way, it also works with an absolute path(without `local://`), but 
it will copy the file to the `user.artifacts.base-dir`. I'm not sure whether 
it's expected (In my opinion, it was a local file, maybe we don't need to copy 
that cc Ferenc Csaky ){quote}

This is a good point, with the current implementation a simple absolute path 
without a prefix will be handled as remote, cause there is a strict check to 
{{local}} scheme, so it ignores {{file}}, which will be present, when a path 
without a prefix is passed. I agree with your opinion and would ocnsider this a 
bug. I would not consider this a major thing that should block the 1.19 
release, but it would be an easy fix, so I can prepare a PR today.

> Release Testing: Verify FLINK-28915 Support artifact fetching in Standalone 
> and native K8s application mode
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-34388
>                 URL: https://issues.apache.org/jira/browse/FLINK-34388
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / Metrics
>    Affects Versions: 1.19.0
>            Reporter: Ferenc Csaky
>            Assignee: Yu Chen
>            Priority: Blocker
>              Labels: release-testing
>             Fix For: 1.19.0
>
>
> This ticket covers testing FLINK-28915. More details and the added docs are 
> accessible on the [PR|https://github.com/apache/flink/pull/24065]
> Test 1: Pass {{local://}} job jar in standalone mode, check the artifacts are 
> not actually copied.
> Test 2: Pass multiple artifacts in standalone mode.
> Test 3: Pass a non-local job jar in native k8s mode. [1]
> Test 4: Pass additional remote artifacts in native k8s mode.
> Available config options: 
> https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/#artifact-fetching
> [1] Custom docker image build instructions: 
> https://github.com/apache/flink-docker/tree/dev-master
> Note: The docker build instructions also contains a web server example that 
> can be used to serve HTTP artifacts.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to