dannycranmer commented on code in PR #24348:
URL: https://github.com/apache/flink/pull/24348#discussion_r1502401147
##########
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/services/HeadlessClusterIPService.java:
##########
@@ -50,6 +50,7 @@ public Service buildUpInternalService(
.withNewMetadata()
.withName(serviceName)
.withLabels(kubernetesJobManagerParameters.getCommonLabels())
+
.withAnnotations(kubernetesJobManagerParameters.getInternalServiceAnnotations())
Review Comment:
This change is not tested. I cannot see an existing test for this method,
and am not sure why that is missing. Can we add one here:
`InternalServiceDecoratorTest` ?
##########
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesJobManagerParameters.java:
##########
@@ -118,6 +118,12 @@ public Map<String, String> getRestServiceAnnotations() {
.orElse(Collections.emptyMap());
}
+ public Map<String, String> getInternalServiceAnnotations() {
+ return flinkConfig
+ .getOptional(KubernetesConfigOptions.REST_SERVICE_ANNOTATIONS)
+ .orElse(Collections.emptyMap());
+ }
+
Review Comment:
Can you please add a test to `KubernetesJobManagerParametersTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
