ljz2051 commented on code in PR #24367:
URL: https://github.com/apache/flink/pull/24367#discussion_r1502571621
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBIncrementalCheckpointUtils.java:
##########
@@ -153,13 +154,14 @@ private static void deleteRange(
byte[] beginKeyBytes,
byte[] endKeyBytes)
throws RocksDBException {
-
+ List<byte[]> deletedRange = Arrays.asList(beginKeyBytes, endKeyBytes);
for (ColumnFamilyHandle columnFamilyHandle : columnFamilyHandles) {
// Using RocksDB's deleteRange will take advantage of delete
// tombstones, which mark the range as deleted.
//
//
https://github.com/ververica/frocksdb/blob/FRocksDB-6.20.3/include/rocksdb/db.h#L363-L377
db.deleteRange(columnFamilyHandle, beginKeyBytes, endKeyBytes);
+ db.deleteFilesInRanges(columnFamilyHandle, deletedRange, false);
Review Comment:
@StefanRRichter Thanks for your advice.
I have made changes according to your comments. Could you take one more
look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
