liuyongvs commented on code in PR #24358:
URL: https://github.com/apache/flink/pull/24358#discussion_r1505243321
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/ReplaceIntersectWithSemiJoinRule.scala:
##########
@@ -49,7 +49,8 @@ class ReplaceIntersectWithSemiJoinRule
val relBuilder = call.builder
val keys = 0 until left.getRowType.getFieldCount
- val conditions = generateEqualsCondition(relBuilder, left, right, keys)
+ val conditions =
+ generateEqualsCondition(relBuilder, left, right,
keys.map(Int.box).toList.asJava)
Review Comment:
@JingGe
we can see two style in many scala Rules files like
keys.map(Int.box).toList.asJava, in
CommonPhysicalLookupJoin/AggregateUtil
map(Integer.valueOf).toList.asJava in many files.
so i change it to your suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
