masteryhx commented on code in PR #24181:
URL: https://github.com/apache/flink/pull/24181#discussion_r1505595039
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java:
##########
@@ -321,6 +321,8 @@ public abstract class StreamTask<OUT, OP extends
StreamOperator<OUT>>
private long initializeStateEndTs;
+ @Nullable private FileMergingSnapshotManager fileMergingSnapshotManager;
Review Comment:
Why this field is not initialized ?
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManager.java:
##########
@@ -118,6 +119,34 @@ FileMergingCheckpointStateOutputStream
createCheckpointStateOutputStream(
*/
Path getManagedDir(SubtaskKey subtaskKey, CheckpointedStateScope scope);
+ /**
Review Comment:
We should remove TODO (L39), right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
