JustinLeesin commented on code in PR #24397:
URL: https://github.com/apache/flink/pull/24397#discussion_r1506925414
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/PlannerCallProcedureOperation.java:
##########
@@ -138,6 +137,14 @@ private Object[] getConvertedArgumentValues(
return argumentVal;
}
+ private ProcedureContext getProcedureContext(TableConfig tableConfig) {
+ Configuration configuration = (Configuration)
tableConfig.getRootConfiguration();
Review Comment:
Yeh ,it's better, but the Configuration class doesn't provide a construct as
Configuration(ReadableConfig config), it has to be : Configuration
configuration = new
Configuration((Configuration)tableConfig.getRootConfiguration());
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
