HuangXingBo commented on code in PR #24417:
URL: https://github.com/apache/flink/pull/24417#discussion_r1508454782
##########
flink-python/pyflink/datastream/state.py:
##########
@@ -809,7 +809,7 @@ def cleanup_incrementally(self,
def cleanup_in_rocksdb_compact_filter(
self,
query_time_after_num_entries,
- periodic_compaction_time=Time.days(30)) -> \
+ periodic_compaction_time=Duration.of_days(30)) -> \
Review Comment:
`Duration.of_days(30)` -> None
##########
flink-python/pyflink/datastream/state.py:
##########
@@ -925,14 +926,14 @@ class
RocksdbCompactFilterCleanupStrategy(CleanupStrategy):
def __init__(self,
query_time_after_num_entries: int,
- periodic_compaction_time=Time.days(30)):
+ periodic_compaction_time=Duration.of_days(30)):
Review Comment:
`Duration.of_days(30)-> None` and do the similar thing to
`cleanup_in_rocksdb_compact_filter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
