huyuanfeng2018 commented on PR #24411: URL: https://github.com/apache/flink/pull/24411#issuecomment-1972635698
> Hi @huyuanfeng2018 thanks for the PR. I have a few comments: > > * Please add `JSON_JOB_PLAN ` to the `python` API (e.g., to the `basic_operations.py`) and test it there as well (e.g., in `test_table_environment.py`) > * Why the `JSON_JOB_PLAN` keyword didn't end up in our parser (`Parser.tdd`, `Parser.jj`)? > * The main motivation behind this PR "' combine it with the parameter `pipeline.jobvertex-parallelism-overrides` to set up my task parallelism'" is not clear to me and is missing in this PR tests > * Add the necessary documentation to the `explain.md` > * Please add test with `Hive` as well (e.g., see `HiveTableSinkITCase::testHiveTableSinkWithParallelismBase` > * Add `JSON_JOB_PLAN ` to the `FlinkSqlParserImplConstants` > * Update `TableTestBase::doVerifyExplain` to support `JSON_JOB_PLAN` as well > * Tests with table API are missing Thank you very much for your review. There is still a lot of work to be done on this PR. I will mark it as a draft first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
