ferenc-csaky commented on code in PR #24436:
URL: https://github.com/apache/flink/pull/24436#discussion_r1512868753
##########
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/utils/JarHandlerUtils.java:
##########
@@ -147,16 +149,14 @@ public void applyToConfiguration(
configuration.set(CoreOptions.DEFAULT_PARALLELISM, parallelism);
final PackagedProgram program = toPackagedProgram(configuration);
+ final List<URL> classpaths = getClasspaths(configuration);
Review Comment:
Since we are always writing back the original content, my thought that is
more obvious this way, but actually if we modify `toPackagedProgram`, that
would result in a more cleaner exception handling as well, so I think it makes
sense to do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
