XComp commented on code in PR #22305:
URL: https://github.com/apache/flink/pull/22305#discussion_r1514669497
##########
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java:
##########
@@ -623,6 +622,7 @@ private void checkResourceRequirements() {
if (resourceAllocator.isSupported()
&& !taskManagerTracker.getPendingTaskManagers().isEmpty())
{
taskManagerTracker.replaceAllPendingAllocations(Collections.emptyMap());
+ checkTaskManagerReleasable();
Review Comment:
@huwh `checkTaskManagerReleasable()` returns a boolean value that is not
verified in any way? Is this intentionally done? The same applies to [line
680](https://github.com/apache/flink/pull/22305/files#diff-76ee49bc1a8829c2944084c64b738ed35e2db217f0981de435fef04816952be6R680).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
