Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2792#discussion_r89088443 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateUtil.scala --- @@ -115,14 +124,210 @@ object AggregateUtil { intermediateRowArity, outputType.getFieldCount) } + groupReduceFunction + } + + /** + * Create IncrementalAggregateReduceFunction for Incremental aggregates. It implement + * [[org.apache.flink.api.common.functions.ReduceFunction]] + * + */ + private[flink] def createIncrementalAggregateReduceFunction( + aggregates: Array[Aggregate[_ <: Any]], --- End diff -- can we just use `namedAggregates` and compute `aggregates` from it?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---