gyfora commented on PR #797: URL: https://github.com/apache/flink-kubernetes-operator/pull/797#issuecomment-1991544918
> Thanks @gyfora for the valuable feedback! > > > Instead of a new rest client you could also do what is done in the Kubernetes-operator module, see: https://github.com/apache/flink-kubernetes-operator/blob/main/flink-kubernetes-operator/src/main/java/org/apache/flink/runtime/rest/messages/job/metrics/IOMetricsInfo.java > > By shadowing the class under the same package this will hide the incompatible implementation coming from flink > > If so, autoscaler works with 1.15 when users uses the `flink-kubernetes-operator`, right? > > I'm using the autoscaler Standalone, and I found 1.15 job doesn't work. In the short term, could I move the `IOMetricsInfo` to autoscaler module? IIUC, it will let both of `flink-kubernetes-operator` and `autoscaler Standalone` work. > > In the long term, should we maintain the `IOMetricsInfo` class in the `flink-kubernetes-operator` repo or we disable `DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES` in the flink repo? > > Looking forward to your opinion, and I'm happy to fix them. > > > But still it will not make it work fully for 1.15 as the aggregated metrics need to be back ported on the Flink side (similar to other features required for the autoscaler) > > Thanks for the reminder, we have a lot of jobs run with 1.15 version, so we are backing port them. Of course, we (our internal platform) only analyse them and don't scale them when the version before 1.18. Not sure if we need to have the IOMetricsInfo override in both packages to be safe actually. I think it has to be copied. I can personally confirm that given the aggregated metrics back ported to 1.15 (easy to do) + the IOMetricsInfo, the autoscaler works with 1.15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
