[ 
https://issues.apache.org/jira/browse/FLINK-34695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827499#comment-17827499
 ] 

Matthias Pohl commented on FLINK-34695:
---------------------------------------

{quote}
Where shall the Docker image code be located?
{quote}

* A docker subfolder in 
[apache/flink:.github/|https://github.com/apache/flink/tree/master/.github] 
since that's the closes it can be to the actual CI. Right now, there is some 
redundancy with 
[apache/flink-connector-shared-utils|https://github.com/apache/flink-connector-shared-utils/blob/ci_utils/docker/base/Dockerfile]
 that is used for connector CI. Having a dedicated CI Docker image in 
{{apache/flink}} would not resolve this redundancy. The question is just: Do we 
want to resolve it?
* Use 
[apache/flink-connector-shared-utils|https://github.com/apache/flink-connector-shared-utils/blob/ci_utils/docker/base/Dockerfile]
 as the Docker image not only for the connector repos but also the Flink main 
repo. This would remove the redundancy.

{quote}
Which Docker registry should be used?
{quote}
* We already use ghcr.io for the Flink nightly builds (see snapshot workflow 
config in 
[apache/flink-docker:.github/workflows/snapshot.yml:24|https://github.com/apache/flink-docker/blob/master/.github/workflows/snapshot.yml#L24].
 That could be used for {{flink-docker-ci}} as well.

> Move Flink's CI docker container into a public repo
> ---------------------------------------------------
>
>                 Key: FLINK-34695
>                 URL: https://issues.apache.org/jira/browse/FLINK-34695
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System / CI
>    Affects Versions: 1.19.0, 1.18.1, 1.20.0
>            Reporter: Matthias Pohl
>            Priority: Major
>
> Currently, Flink's CI (GitHub Actions and Azure Pipelines) use a container to 
> run the logic. The intention behind it is to have a way to mimick the CI 
> setup locally as well.
> The current Docker image is maintained from the 
> [zentol/flink-ci-docker|https://github.com/zentol/flink-ci-docker] fork 
> (owned by [~chesnay]) of 
> [flink-ci/flink-ci-docker|https://github.com/flink-ci/flink-ci-docker] (owned 
> by Ververica) which is not ideal. We should move this repo into a 
> Apache-owned repository.
> Additionally, the there's no workflow pushing the image automatically to a 
> registry from where it can be used. Instead, the images were pushed to 
> personal Docker Hub repos in the past (rmetzger, chesnay, mapohl). This is 
> also not ideal. We should use a public repo using a GHA workflow to push the 
> image to that repo.
> Questions to answer here:
> # Where shall the Docker image code be located?
> # Which Docker registry should be used?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to