[
https://issues.apache.org/jira/browse/FLINK-34715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827885#comment-17827885
]
Xin Gong commented on FLINK-34715:
----------------------------------
[~Leonard] PTAL
> Fix mysql ut about closing BinlogSplitReader
> --------------------------------------------
>
> Key: FLINK-34715
> URL: https://issues.apache.org/jira/browse/FLINK-34715
> Project: Flink
> Issue Type: Improvement
> Components: Flink CDC
> Reporter: Xin Gong
> Priority: Minor
> Labels: pull-request-available
> Fix For: cdc-3.1.0
>
>
> BinlogSplitReaderTest#readBinlogSplitsFromSnapshotSplits should test binlog
> reader is closed after binlog reader close. But code always test snapshot
> split reader is closed.
> {code:java}
> binlogReader.close();
> assertNotNull(snapshotSplitReader.getExecutorService());
> assertTrue(snapshotSplitReader.getExecutorService().isTerminated());{code}
> We shoud change code to
> {code:java}
> binlogReader.close();
> assertNotNull(binlogReader.getExecutorService());
> assertTrue(binlogReader.getExecutorService().isTerminated()); {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
