affo commented on code in PR #132:
URL:
https://github.com/apache/flink-connector-aws/pull/132#discussion_r1528260831
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/table/util/KinesisStreamsConnectorOptionsUtils.java:
##########
@@ -148,13 +149,13 @@ public static class KinesisProducerOptionsMapper {
public KinesisProducerOptionsMapper(
ReadableConfig tableOptions, Map<String, String>
resolvedOptions) {
this.tableOptions = tableOptions;
- this.resolvedOptions = resolvedOptions;
+ this.resolvedOptions = new HashMap<>(resolvedOptions);
Review Comment:
Just a knit, I would specify as field type:
```java
private final HashMap<String, String> resolvedOptions;
```
To make it explicit that we need a mutable Map internally (`HashMap` instead
of `Map`), maybe also adding a comment on top would not hurt, otherwise the Map
clone operation in the constructor would end up being rather obscure 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
