alexey-lv commented on code in PR #24534:
URL: https://github.com/apache/flink/pull/24534#discussion_r1530610432
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/join/TemporalJoinTest.scala:
##########
@@ -508,6 +508,27 @@ class TemporalJoinTest extends TableTestBase {
" table, but the rowtime types are TIMESTAMP_LTZ(3) *ROWTIME* and
TIMESTAMP(3) *ROWTIME*.",
classOf[ValidationException]
)
+
+ val sqlQuery9 = "SELECT * " +
+ "FROM Orders AS o JOIN " +
+ "RatesHistoryWithPK FOR SYSTEM_TIME AS OF 'o.rowtime' AS r " +
+ "ON o.currency = r.currency"
+ expectExceptionThrown(
+ sqlQuery9,
+ "The system time period specification expects Timestamp type but is
'CHAR'",
Review Comment:
nit: the error message would be better if it was changed `...expects
Timestamp type but is...` --> `...expects Timestamp type, but got ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
