PatrickRen commented on code in PR #3168: URL: https://github.com/apache/flink-cdc/pull/3168#discussion_r1531445066
########## docs/content.zh/docs/connectors/legacy-flink-cdc-sources/db2-cdc.md: ########## @@ -32,9 +32,9 @@ describes how to setup the db2 CDC connector to run SQL queries against Db2 data ## Supported Databases -| Connector | Database | Driver | -|-----------------------|----------------------------------------------------|----------------------| -| [Db2-cdc](../db2-cdc) | <li> [Db2](https://www.ibm.com/products/db2): 11.5 | Db2 Driver: 11.5.0.0 | +| Connector | Database | Driver | +|-----------|----------------------------------------------------|----------------------| +| Db2-cdc | <li> [Db2](https://www.ibm.com/products/db2): 11.5 | Db2 Driver: 11.5.0.0 | Review Comment: What about using `{{ < ref > }}` here instead of removing the link? ########## docs/content/docs/connectors/legacy-flink-cdc-sources/mysql-cdc.md: ########## @@ -31,9 +31,9 @@ The MySQL CDC connector allows for reading snapshot data and incremental data fr ## Supported Databases -| Connector | Database | Driver | -|---------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-------------------------| -| [mysql-cdc](../mysql-cdc) | <li> [MySQL](https://dev.mysql.com/doc): 5.6, 5.7, 8.0.x <li> [RDS MySQL](https://www.aliyun.com/product/rds/mysql): 5.6, 5.7, 8.0.x <li> [PolarDB MySQL](https://www.aliyun.com/product/polardb): 5.6, 5.7, 8.0.x <li> [Aurora MySQL](https://aws.amazon.com/cn/rds/aurora): 5.6, 5.7, 8.0.x <li> [MariaDB](https://mariadb.org): 10.x <li> [PolarDB X](https://github.com/ApsaraDB/galaxysql): 2.0.1 | JDBC Driver: 8.0.27 | +| Connector | Database | Driver | +|-----------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------------| +| mysql-cdc | <li> [MySQL](https://dev.mysql.com/doc): 5.6, 5.7, 8.0.x <li> [RDS MySQL](https://www.aliyun.com/product/rds/mysql): 5.6, 5.7, 8.0.x <li> [PolarDB MySQL](https://www.aliyun.com/product/polardb): 5.6, 5.7, 8.0.x <li> [Aurora MySQL](https://aws.amazon.com/cn/rds/aurora): 5.6, 5.7, 8.0.x <li> [MariaDB](https://mariadb.org): 10.x <li> [PolarDB X](https://github.com/ApsaraDB/galaxysql): 2.0.1 | JDBC Driver: 8.0.27 | Review Comment: Use {{< ref >}} here ########## docs/content.zh/docs/connectors/legacy-flink-cdc-sources/mysql-cdc.md: ########## @@ -31,9 +31,9 @@ The MySQL CDC connector allows for reading snapshot data and incremental data fr ## Supported Databases -| Connector | Database | Driver | -|---------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-------------------------| -| [mysql-cdc](../mysql-cdc) | <li> [MySQL](https://dev.mysql.com/doc): 5.6, 5.7, 8.0.x <li> [RDS MySQL](https://www.aliyun.com/product/rds/mysql): 5.6, 5.7, 8.0.x <li> [PolarDB MySQL](https://www.aliyun.com/product/polardb): 5.6, 5.7, 8.0.x <li> [Aurora MySQL](https://aws.amazon.com/cn/rds/aurora): 5.6, 5.7, 8.0.x <li> [MariaDB](https://mariadb.org): 10.x <li> [PolarDB X](https://github.com/ApsaraDB/galaxysql): 2.0.1 | JDBC Driver: 8.0.27 | +| Connector | Database | Driver | +|-----------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------------| +| mysql-cdc | <li> [MySQL](https://dev.mysql.com/doc): 5.6, 5.7, 8.0.x <li> [RDS MySQL](https://www.aliyun.com/product/rds/mysql): 5.6, 5.7, 8.0.x <li> [PolarDB MySQL](https://www.aliyun.com/product/polardb): 5.6, 5.7, 8.0.x <li> [Aurora MySQL](https://aws.amazon.com/cn/rds/aurora): 5.6, 5.7, 8.0.x <li> [MariaDB](https://mariadb.org): 10.x <li> [PolarDB X](https://github.com/ApsaraDB/galaxysql): 2.0.1 | JDBC Driver: 8.0.27 | Review Comment: Also I think it's better to keep the link here ########## .dlc.json: ########## @@ -0,0 +1,44 @@ +{ + "ignorePatterns": [ + { + "pattern": "^http://localhost"; + }, + { + "pattern": "^#" + }, + { + "pattern": "^{" + }, + { + "pattern": "^https://repo1.maven.org/maven2/org/apache/flink.*SNAPSHOT.*"; + }, + { + "pattern": "^https://mvnrepository.com"; + }, + { + "pattern": "^https://img.shields.io"; + }, + { + "pattern": "^https://tokei.rs"; + }, + { + "pattern": "^https://json.org/"; + }, + { + "pattern": "^https://opencollective.com"; + }, + { + "pattern": "^https://twitter.com*"; + } Review Comment: Do we have these links in the documentation? ########## docs/content/docs/connectors/legacy-flink-cdc-sources/db2-cdc.md: ########## @@ -32,9 +32,9 @@ describes how to setup the db2 CDC connector to run SQL queries against Db2 data ## Supported Databases -| Connector | Database | Driver | -|-----------------------|----------------------------------------------------|----------------------| -| [Db2-cdc](../db2-cdc) | <li> [Db2](https://www.ibm.com/products/db2): 11.5 | Db2 Driver: 11.5.0.0 | +| Connector | Database | Driver | +|-----------|----------------------------------------------------|----------------------| +| Db2-cdc | <li> [Db2](https://www.ibm.com/products/db2): 11.5 | Db2 Driver: 11.5.0.0 | Review Comment: Use `{{< ref >}}` here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
