1996fanrui opened a new pull request, #808:
URL: https://github.com/apache/flink-kubernetes-operator/pull/808

   ## What is the purpose of the change
   
   DBC Autoscaler event handler doesn't allow the event message is null, but 
the message may be null when we handle the exception.
   
   We consider the exception message as the event message, but the exception 
message may be null, such as: TimeoutException. (It has been shown in following 
picture.)
   
   Also, ecording a event without any message is meaningless. It doesn't have 
any benefit for troubleshooting.
   
   
   
   ## Brief change log
   
   - [FLINK-34957][autoscaler] Event handler records the exception stack trace 
when exception message is null
     - Consider the exception message as the event message when exception 
message isn't null
     - The whole Exception as the event message if exception message is null.
   
   ## Verifying this change
   
   Test manually, it works well. We can see the detailed exception from the 
`LoggingEventHandler`.
   
   <img width="1630" alt="image" 
src="https://github.com/apache/flink-kubernetes-operator/assets/38427477/ff4ed621-241e-43f5-a4a2-b4fb322f07ea";>
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency):  no
     - The public API, i.e., is any changes to the `CustomResourceDescriptors`: 
no
     - Core observer or reconciler logic that is regularly executed: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to