zentol commented on code in PR #24562: URL: https://github.com/apache/flink/pull/24562#discussion_r1542463838
########## flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunnerTest.java: ########## @@ -499,11 +499,33 @@ void testResultFutureCompletionOfOutdatedLeaderIsIgnored() throws Exception { leaderElection.notLeader(); + assertThat(jobManagerRunner.getResultFuture()) + .as("The runner result should not be completed by the leadership revocation.") + .isNotDone(); + resultFuture.complete( JobManagerRunnerResult.forSuccess( createFailedExecutionGraphInfo(new FlinkException("test exception")))); - assertThatFuture(jobManagerRunner.getResultFuture()).eventuallyFails(); + assertThat(jobManagerRunner.getResultFuture()) + .as("The runner result should be completed if the leadership is lost.") + .isNotDone(); Review Comment: the message doesnt match the assertion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org