[
https://issues.apache.org/jira/browse/FLINK-34933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Pohl resolved FLINK-34933.
-----------------------------------
Fix Version/s: 1.18.2
1.20.0
1.19.1
Resolution: Fixed
master:
[1668a07276929416469392a35a77ba7699aac30b|https://github.com/apache/flink/commit/1668a07276929416469392a35a77ba7699aac30b]
1.19:
[c11656a2406f07e2ae7cd6f80c46afb14385ee0e|https://github.com/apache/flink/commit/c11656a2406f07e2ae7cd6f80c46afb14385ee0e]
1.18:
[94d1363c27e26fc8313721e138c7b4de744ca69e|https://github.com/apache/flink/commit/94d1363c27e26fc8313721e138c7b4de744ca69e]
> JobMasterServiceLeadershipRunnerTest#testResultFutureCompletionOfOutdatedLeaderIsIgnored
> isn't implemented properly
> -------------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-34933
> URL: https://issues.apache.org/jira/browse/FLINK-34933
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Coordination
> Affects Versions: 1.17.2, 1.19.0, 1.18.1, 1.20.0
> Reporter: Matthias Pohl
> Assignee: Matthias Pohl
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.18.2, 1.20.0, 1.19.1
>
>
> {{testResultFutureCompletionOfOutdatedLeaderIsIgnored}} doesn't test the
> desired behavior: The {{TestingJobMasterService#closeAsync()}} callback
> throws an {{UnsupportedOperationException}} by default which prevents the
> test from properly finalizing the leadership revocation.
> The test is still passing because the test checks implicitly for this error.
> Instead, we should verify that the runner's resultFuture doesn't complete
> until the runner is closed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
