masteryhx commented on code in PR #24480:
URL: https://github.com/apache/flink/pull/24480#discussion_r1545946971
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/metadata/MetadataV2V3SerializerBase.java:
##########
@@ -677,6 +734,18 @@ static void serializeStreamStateHandle(StreamStateHandle
stateHandle, DataOutput
RelativeFileStateHandle relativeFileStateHandle =
(RelativeFileStateHandle) stateHandle;
dos.writeUTF(relativeFileStateHandle.getRelativePath());
dos.writeLong(relativeFileStateHandle.getStateSize());
+ } else if (stateHandle instanceof SegmentFileStateHandle) {
+ if (stateHandle instanceof EmptySegmentFileStateHandle) {
+ dos.writeByte(EMPTY_SEGMENT_FILE_HANDLE);
Review Comment:
This `serializeStreamStateHandle` is used when serialize
`EmptyFileMergingOperatorStreamStateHandle` which holds this as its delegated
empty stream state handle.
So it's still needed, right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
