Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2509#discussion_r89283859
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09Fetcher.java
---
@@ -306,13 +340,23 @@ public void run() {
}
}
- // Kafka09Fetcher ignores the timestamp, Kafka010Fetcher is extracting
the timestamp and passing it to the emitRecord() method.
+ //
------------------------------------------------------------------------
+ // Protected methods that allow pluggable Kafka version-specific
implementations
+ //
------------------------------------------------------------------------
+
protected void emitRecord(T record,
KafkaTopicPartitionState<TopicPartition> partition, long offset, ConsumerRecord
consumerRecord) throws Exception {
+ // Kafka09Fetcher ignores the timestamp, Kafka010Fetcher is
extracting the timestamp and passing it to the emitRecord() method.
emitRecord(record, partition, offset, Long.MIN_VALUE);
--- End diff --
This will probably break as well when rebasing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
