[ 
https://issues.apache.org/jira/browse/FLINK-21943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833008#comment-17833008
 ] 

Weijie Guo commented on FLINK-21943:
------------------------------------

In fact, for this kind of issue there is no need to create a JIRA ticket, a 
hot-fix is more appropriate. Given that this ticket has been around for a long 
time, let's leave it as it is.

> Redundant checkNotNull in Transformation#setResources
> -----------------------------------------------------
>
>                 Key: FLINK-21943
>                 URL: https://issues.apache.org/jira/browse/FLINK-21943
>             Project: Flink
>          Issue Type: Improvement
>          Components: API / Core
>    Affects Versions: 1.20.0
>            Reporter: ZhangWei
>            Priority: Minor
>              Labels: pull-request-available
>
> In org.apache.flink.api.dag.Transformation#setResources(ResourceSpec 
> minResources, ResourceSpec preferredResources),
> we have already checked that the parameters are not null by 
> calling OperatorValidationUtils#validateMinAndPreferredResources.
> so it is not necessary to check again in setResources(
> ) , just assign the parameters.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to