[ 
https://issues.apache.org/jira/browse/FLINK-5023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15689795#comment-15689795
 ] 

ASF GitHub Bot commented on FLINK-5023:
---------------------------------------

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/2768
  
    @shixiaogang Thanks for the swift update! The changes look very good now 
though I found one last thing that could be problematic. This is changing the 
behaviour of `FoldingState` when it comes to the default value. I'll quickly 
open a PR that verifies the current behaviour.


> Add get() method in State interface
> -----------------------------------
>
>                 Key: FLINK-5023
>                 URL: https://issues.apache.org/jira/browse/FLINK-5023
>             Project: Flink
>          Issue Type: Improvement
>          Components: State Backends, Checkpointing
>            Reporter: Xiaogang Shi
>            Assignee: Xiaogang Shi
>
> Currently, the only method provided by the State interface is `clear()`. I 
> think we should provide another method called `get()` to return the 
> structured value (e.g., value, list, or map) under the current key. 
> In fact, the functionality of `get()` has already been implemented in all 
> types of states: e.g., `value()` in ValueState and `get()` in ListState. The 
> modification to the interface can better abstract these states.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to