1996fanrui commented on code in PR #811:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/811#discussion_r1554828200
##########
flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/StandaloneAutoscalerEntrypoint.java:
##########
@@ -60,9 +60,11 @@ public static <KEY, Context extends
JobAutoScalerContext<KEY>> void main(String[
var autoScaler = createJobAutoscaler(eventHandler, stateStore);
- var autoscalerExecutor =
- new StandaloneAutoscalerExecutor<>(conf, jobListFetcher,
eventHandler, autoScaler);
- autoscalerExecutor.start();
+ try (var autoscalerExecutor =
+ new StandaloneAutoscalerExecutor<>(
+ conf, jobListFetcher, eventHandler, autoScaler)) {
+ autoscalerExecutor.start();
+ }
Review Comment:
Hey @plugatarev , thanks for the PR!
IIUC, we cannot close `StandaloneAutoscalerExecutor`. We expect
StandaloneAutoscalerExecutor scaling jobs periodically. It will stop work if we
close executor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
