Zakelly commented on code in PR #24614: URL: https://github.com/apache/flink/pull/24614#discussion_r1555239594
########## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/StateExecutor.java: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.asyncprocessing; + +import org.apache.flink.annotation.Internal; + +import java.util.concurrent.CompletableFuture; + +/** Executor for executing batch {@link StateRequest}s. */ +@Internal +public interface StateExecutor { + /** + * Execute a batch of state requests. + * + * @param processingRequests the given batch of processing requests + * @return A future can determine whether execution has completed. + */ + CompletableFuture<Boolean> executeBatchRequests( + Iterable<StateRequest<?, ?, ?>> processingRequests); Review Comment: The sorting and batching in group is finished by the `AEC`, there is no mixed types of requests here. Here we just follow the description of the FLIPs, if we need to change the signature here, it would be fine change this later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
