[ 
https://issues.apache.org/jira/browse/FLINK-5103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15689902#comment-15689902
 ] 

ASF GitHub Bot commented on FLINK-5103:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2833
  
    There is currently a metric group `JVM` already. This adds a metric group 
`Process`. What is the difference between the two? Can the new metrics be added 
to the `JVM` group instead? That would help to prevent fragmenting the metric 
groups.
    
    I would also suggest to move the code that accesses CPU utilization into 
the `Hardware` class. That is where we put code that uses OS specific utilities 
to access for example memory and CPU.
    Please also use the `OperatingSystem` class to identify operating systems.


> TaskManager process virtual memory and physical memory used size gauge
> ----------------------------------------------------------------------
>
>                 Key: FLINK-5103
>                 URL: https://issues.apache.org/jira/browse/FLINK-5103
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>            Reporter: zhuhaifeng
>            Assignee: zhuhaifeng
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> Add TaskManger Process virtual memory and physical memory used size gauge 
> metrics.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to