uce commented on code in PR #90:
URL:
https://github.com/apache/flink-connector-kafka/pull/90#discussion_r1559195113
##########
flink-python/pyflink/pyflink_gateway_server.py:
##########
@@ -71,7 +71,7 @@ def read_from_config(key, default_value, flink_conf_file):
def find_java_executable():
java_executable = "java.exe" if on_windows() else "java"
flink_home = _find_flink_home()
- flink_conf_file = os.path.join(flink_home, "conf", "flink-conf.yaml")
+ flink_conf_file = os.path.join(flink_home, "conf", "config.yaml")
Review Comment:
We need a fallback to `flink-conf.yaml` for the older versions. Otherwise,
this LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
