zhongqishang commented on code in PR #3145:
URL: https://github.com/apache/flink-cdc/pull/3145#discussion_r1559444901
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/utils/MySqlTypeUtils.java:
##########
@@ -218,7 +218,9 @@ private static DataType convertFromColumn(Column column) {
case MULTILINESTRING:
return DataTypes.STRING();
case BINARY:
- return DataTypes.BINARY(column.length());
+ return column.length() > 0
Review Comment:
@PatrickRen Thank you for your detailed explanation, I have modified it.
Please take a look again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]