PatrickRen commented on code in PR #3186:
URL: https://github.com/apache/flink-cdc/pull/3186#discussion_r1560388633
##########
docs/content/docs/connectors/mysql.md:
##########
@@ -205,6 +205,16 @@ pipeline:
<td>Integer</td>
<td>The connection pool size.</td>
</tr>
+ <tr>
+ <td>table.exclude.list</td>
Review Comment:
TBH I'm not in favor of adding this option. It reminds me the nightmare
using `maven-shade-plugin` that also [supports both include and
exclude](https://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html),
which always make me confused about the priority of these two options.
[Debezium](https://debezium.io/documentation/reference/2.6/connectors/mysql.html#mysql-property-table-exclude-list)
also doesn't support setting both inclusion and exclusion together.
The `tables` option uses regex for matching the table id. Considering regex
itself supports negation, what about controlling the exclusion list using the
negation in regex?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
