[
https://issues.apache.org/jira/browse/FLINK-32582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836087#comment-17836087
]
Martijn Visser commented on FLINK-32582:
----------------------------------------
[~mapohl] What was the plan on this ticket? We're now in the situation that the
Flink Kafka connector can't compile for 1.20-SNAPSHOT, see
https://github.com/apache/flink-connector-kafka/actions/runs/8644888490/job/23700957245#step:15:146
{code:java}
Error: COMPILATION ERROR :
[INFO] -------------------------------------------------------------
Error:
/home/runner/work/flink-connector-kafka/flink-connector-kafka/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/TypeSerializerUpgradeTestBase.java:[139,15]
exception java.io.IOException is never thrown in body of corresponding try
statement
Error:
/home/runner/work/flink-connector-kafka/flink-connector-kafka/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/TypeSerializerUpgradeTestBase.java:[150,15]
exception java.io.IOException is never thrown in body of corresponding try
statement
Error:
/home/runner/work/flink-connector-kafka/flink-connector-kafka/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/TypeSerializerUpgradeTestBase.java:[182,15]
exception java.io.IOException is never thrown in body of corresponding try
statement
Error:
/home/runner/work/flink-connector-kafka/flink-connector-kafka/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/TypeSerializerUpgradeTestBase.java:[194,15]
exception java.io.IOException is never thrown in body of corresponding try
statement
Error:
/home/runner/work/flink-connector-kafka/flink-connector-kafka/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/TypeSerializerUpgradeTestBase.java:[206,15]
exception java.io.IOException is never thrown in body of corresponding try
statement
{code}
> Move TypeSerializerUpgradeTestBase from Kafka connector into
> flink-connector-common
> -----------------------------------------------------------------------------------
>
> Key: FLINK-32582
> URL: https://issues.apache.org/jira/browse/FLINK-32582
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / Common
> Reporter: Matthias Pohl
> Priority: Minor
> Labels: auto-deprioritized-major, pull-request-available
>
> The externalization of connectors caused problems with the Flink's test data
> generation. The Kafka connector relied on TypeSerializerUpgradeTestBase for
> some test cases which was fine prior to FLINK-27518 where the test data
> generation was handled individually.
> With FLINK-27518 the process was automated in Flink 1.18. For now, the
> TypeSerializerUpgradeTestBase class was just copied over into the Kafka
> connector since it was the only connector that would utilize this test base.
> But we might want to provide a more generalized solution where the test base
> is provided by {{flink-connector-common}} to offer a generalized approach for
> any connector.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
