[
https://issues.apache.org/jira/browse/FLINK-35040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836091#comment-17836091
]
Rui Fan edited comment on FLINK-35040 at 4/11/24 10:16 AM:
-----------------------------------------------------------
Hi [~slfan1989] , thanks for your quick feedback!
FLINK-34955 wants to fix CVE issues of {{{}common-compress{}}}, but it upgrades
the {{commons-io}} together. I try to revert {{commons-io}} to 2.11.0, and the
performance is recovered.
My question is why do you upgrade the commons-io in FLINK-34955, and I didn't
see any vulnerabilities for commons-io. Could I revert {{commons-io}} to 2.11.0?
Note: I revert {{commons-io}} to 2.11.0, and upgrade commons-compress to
2.16.1, then run the benchmark once, the performance is recovered.
I try to only revert {{commons-io}} to 2.11.0(See the PR), trigger benchmark
twice, and see the performance result later. (The benchmark server is busy, so
the result may be finished tomorrow.)
was (Author: fanrui):
Hi [~slfan1989] , thanks for your quick feedback!
FLINK-34955 wants to fix CVE issues of {{{}common-compress{}}}, but it upgrades
the {{commons-io}} together. I try to revert {{commons-io}} to 2.11.0, and the
performance is recovered.
My question is why do you upgrade the commons-io in FLINK-34955, and I didn't
see any vulnerabilities for commons-io. Could I revert {{commons-io}} to 2.11.0?
Note: I revert {{commons-io}} to 2.11.0, and upgrade commons-compress to
2.16.1, then run the benchmark once, the performance is recovered.
I try to only revert {{commons-io}} to 2.11.0, trigger benchmark twice, and see
the performance result later. (The benchmark server is busy, so the result may
be finished tomorrow.)
> The performance of serializerHeavyString regresses since April 3
> ----------------------------------------------------------------
>
> Key: FLINK-35040
> URL: https://issues.apache.org/jira/browse/FLINK-35040
> Project: Flink
> Issue Type: Bug
> Components: Benchmarks
> Affects Versions: 1.20.0
> Reporter: Rui Fan
> Assignee: Rui Fan
> Priority: Blocker
> Labels: pull-request-available
> Attachments: image-2024-04-08-10-51-07-403.png,
> image-2024-04-11-12-53-53-353.png, screenshot-1.png
>
>
> The performance of serializerHeavyString regresses since April 3, and had not
> yet recovered on April 8th.
> It seems Java 11 regresses, and Java 8 and Java 17 are fine.
> http://flink-speed.xyz/timeline/#/?exe=1,6,12&ben=serializerHeavyString&extr=on&quarts=on&equid=off&env=3&revs=200
> !screenshot-1.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
