liuml07 commented on code in PR #22547:
URL: https://github.com/apache/flink/pull/22547#discussion_r1563862180
##########
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorResourceUtils.java:
##########
@@ -285,4 +286,15 @@ private static <T> void setConfigOptionToDefaultIfNotSet(
config.set(option, defaultValue);
}
}
+
+ private static <T> void resetConfigOption(
+ Configuration config, ConfigOption<T> option, T value) {
+ if (config.contains(option)) {
+ LOG.info(
+ "The configuration option {} has no effect for local
execution, resetting to {}",
+ option.key(),
+ value);
+ }
+ config.set(option, value);
+ }
Review Comment:
Yes this makes sense. After removing them, I find we can be simply set the
valid default config value, instead of checking first. So
`silentlySetConfigOptionIfNotSet()` and it's callsites are just removed. A bit
simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
