empathy87 commented on PR #24659:
URL: https://github.com/apache/flink/pull/24659#issuecomment-2054089997
> Hi @empathy87 thanks a lot for driving this PR. It looks good to me. Could
you please add tests for each changelog in 'OrcFilters.java' ? Thanks!
Sure! I reworked the tests to cover all changes in `OrcFilters.java`.
Please, note that expressions like **10 > y** could not be tested by
executing SQL queries. This is because Filesystem connector predicate push down
works in a best effort manner. And if extra rows are returned from the ORC
file, they will be further filtered out.
Expressions like **10 > y** are tested in
`OrcFileSystemFilterTest::testApplyPredicateReverse` to assert that it is
converted to **y < 10** ORC filer predicate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
