klam-shop commented on code in PR #24482: URL: https://github.com/apache/flink/pull/24482#discussion_r1565935343
########## flink-formats/flink-protobuf-confluent-registry/src/test/java/org/apache/flink/formats/protobuf/registry/confluent/utils/FlinkToProtoSchemaConverterTest.java: ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.formats.protobuf.registry.confluent.utils; + +import org.apache.flink.table.types.logical.MultisetType; +import org.apache.flink.table.types.logical.RowType; +import org.apache.flink.table.types.logical.RowType.RowField; +import org.apache.flink.table.types.logical.VarCharType; +import org.apache.flink.util.TestLoggerExtension; + +import com.google.protobuf.Descriptors.Descriptor; +import io.confluent.kafka.schemaregistry.protobuf.ProtobufSchema; +import org.junit.jupiter.api.extension.ExtendWith; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.Arguments; +import org.junit.jupiter.params.provider.MethodSource; + +import java.util.Collections; +import java.util.stream.Stream; + +import static org.assertj.core.api.Assertions.assertThat; + +/** Tests for {@link FlinkToProtoSchemaConverter}. */ +@ExtendWith(TestLoggerExtension.class) +class FlinkToProtoSchemaConverterTest { Review Comment: > if we are converting from the rowType the protobuf schema will only have 1 (root) element. IIUC, we won't have a case which is similar to what is outlined in [wire-format](https://docs.confluent.io/platform/current/schema-registry/fundamentals/serdes-develop/index.html#wire-format) example. Yep, I agree with that. My point was just that the serializer code assumes 1 root element and is not tightly coupled t to the rowType -> protobuf schema code. If the rowType -> protobuf schema code changes such that theres more than 1 root element, but the serializer is not updated, it will continue to write empty message indices, which would be incorrect. So, to avoid that scenario, I suggest considering to add a test to assert there's only 1 root element (and maybe a comment saying if you're removing this test, you may need to update the serialization code to handle message indices) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
