xintongsong commented on code in PR #22547:
URL: https://github.com/apache/flink/pull/22547#discussion_r1566773890
##########
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorResourceUtils.java:
##########
@@ -285,4 +286,15 @@ private static <T> void setConfigOptionToDefaultIfNotSet(
config.set(option, defaultValue);
}
}
+
+ private static <T> void resetConfigOption(
+ Configuration config, ConfigOption<T> option, T value) {
+ if (config.contains(option)) {
+ LOG.info(
+ "The configuration option {} has no effect for local
execution, resetting to {}",
+ option.key(),
+ value);
+ }
+ config.set(option, value);
+ }
Review Comment:
I see you've already trigger the CI with a git push. Next time you can
simply comment `@flinkbot run azure` on the PR.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorResourceUtils.java:
##########
@@ -285,4 +286,15 @@ private static <T> void setConfigOptionToDefaultIfNotSet(
config.set(option, defaultValue);
}
}
+
+ private static <T> void resetConfigOption(
+ Configuration config, ConfigOption<T> option, T value) {
+ if (config.contains(option)) {
+ LOG.info(
+ "The configuration option {} has no effect for local
execution, resetting to {}",
+ option.key(),
+ value);
+ }
+ config.set(option, value);
+ }
Review Comment:
I see you've already trigger the CI with a git push. Next time you can
simply comment `@flinkbot run azure` on the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
