Zakelly commented on code in PR #24644:
URL: https://github.com/apache/flink/pull/24644#discussion_r1568486250


##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java:
##########
@@ -349,6 +350,13 @@ private long uploadSnapshotFiles(
                                 ? CheckpointedStateScope.EXCLUSIVE
                                 : CheckpointedStateScope.SHARED;
 
+                // Report the reuse of state handle to stream factory, which 
is essential for file
+                // merging mechanism.
+                checkpointStreamFactory.reusePreviousStateHandle(

Review Comment:
   Nope. This could be optimized later. (This PR considers the file reusing 
only, not newly introduced files)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to