fredia commented on code in PR #24667: URL: https://github.com/apache/flink/pull/24667#discussion_r1568656329
########## flink-core/src/main/java/org/apache/flink/configuration/ExecutionOptions.java: ########## @@ -181,4 +182,73 @@ public class ExecutionOptions { + " operators. NOTE: It takes effect only in the BATCH runtime mode and requires sorted inputs" + SORT_INPUTS.key() + " to be enabled."); + + /** + * A flag to enable or disable async mode related components when tasks initialize. As long as + * this option is enabled, the state access of Async state APIs will be executed asynchronously. + * Otherwise, the state access of Async state APIs will be executed synchronously. For Sync + * state APIs, the state access is always executed synchronously, enable this option would bring + * some overhead. + * + * <p>Note: This is an experimental feature(FLIP-425) under evaluation. + */ + @Experimental + public static final ConfigOption<Boolean> ASYNC_STATE_ENABLED = + ConfigOptions.key("execution.async-mode.enabled") + .booleanType() + .defaultValue(false) + .withDescription( + "A flag to enable or disable async mode related components when tasks initialize." + + " As long as this option is enabled, the state access of Async state APIs will be executed asynchronously." + + " Otherwise, the state access of Async state APIs will be executed synchronously." + + " For Sync state APIs, the state access is always executed synchronously, enable this option would bring some overhead.\n" Review Comment: Thanks for your insight, after discussing offline, we think it would be better to expose it on the data stream API in some way so that users can enable async execution in a more fine-grained manner. So, this option is removed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org