fredia commented on code in PR #24672:
URL: https://github.com/apache/flink/pull/24672#discussion_r1568731699
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerServiceImpl.java:
##########
@@ -117,6 +120,7 @@ public class InternalTimerServiceImpl<K, N> implements
InternalTimerService<N> {
startIdx = Math.min(keyGroupIdx, startIdx);
}
this.localKeyGroupRangeStartIdx = startIdx;
+ this.processingTimeCallback = this::onProcessingTime;
Review Comment:
The original idea was to avoid rewriting `startTimerService()` and
`registerProcessingTimeTimer` by introducing `processingTimeCallback`, since it
needs to be reassigned in the subclass, it cannot be marked as `final`.
For the `onAsyncProcessingTime`, I changed it back to `onProcessingTime`,
BTW, `onProcessingTime()` is a private method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
