ljz2051 commented on code in PR #24681: URL: https://github.com/apache/flink/pull/24681#discussion_r1572151847
########## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStValueState.java: ########## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.state.forst; + +import org.apache.flink.api.common.state.v2.ValueState; +import org.apache.flink.core.memory.DataInputDeserializer; +import org.apache.flink.core.memory.DataOutputSerializer; +import org.apache.flink.runtime.asyncprocessing.StateRequestHandler; +import org.apache.flink.runtime.state.SerializedCompositeKeyBuilder; +import org.apache.flink.runtime.state.v2.InternalValueState; +import org.apache.flink.runtime.state.v2.ValueStateDescriptor; + +import org.rocksdb.ColumnFamilyHandle; + +import java.io.IOException; + +/** + * The {@link InternalValueState} implement for ForStDB. + * + * @param <K> The type of the key. + * @param <V> The type of the value. + */ +public class ForStValueState<K, V> extends InternalValueState<K, V> + implements ValueState<V>, ForStInnerTable<ContextKey<K>, V> { + + /** The column family which this internal value state belongs to. */ + private final ColumnFamilyHandle columnFamilyHandle; + + /** The serialized key builder which need be thread-safe. */ + private final ThreadLocal<SerializedCompositeKeyBuilder<K>> serializedKeyBuilder; + + /** The data outputStream used for value serializer, which need be thread-safe. */ + private final ThreadLocal<DataOutputSerializer> valueSerializerView; + + /** The data inputStream used for value deserializer, which need be thread-safe. */ + private final ThreadLocal<DataInputDeserializer> valueDeserializerView; + + public ForStValueState( + StateRequestHandler stateRequestHandler, + ColumnFamilyHandle columnFamily, + ValueStateDescriptor<V> valueStateDescriptor, + ThreadLocal<SerializedCompositeKeyBuilder<K>> serializedKeyBuilder, + ThreadLocal<DataOutputSerializer> valueSerializerView, + ThreadLocal<DataInputDeserializer> valueDeserializerView) { + super(stateRequestHandler, valueStateDescriptor); + this.columnFamilyHandle = columnFamily; + this.serializedKeyBuilder = serializedKeyBuilder; + this.valueSerializerView = valueSerializerView; + this.valueDeserializerView = valueDeserializerView; + } + + @Override + public ColumnFamilyHandle getColumnFamilyHandle() { + return columnFamilyHandle; + } + + @Override + public byte[] serializeKey(ContextKey<K> contextKey) throws IOException { Review Comment: Yes. I have marked the ContextKey with @ThreadSafe annotation, and refactor the 'read cache or serialize' logic. Please review the ContextKey#getOrCreateSerializedKey method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
