eskabetxe commented on code in PR #115:
URL:
https://github.com/apache/flink-connector-jdbc/pull/115#discussion_r1572162247
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcConnectionOptions.java:
##########
@@ -90,13 +98,31 @@ public JdbcConnectionOptionsBuilder withDriverName(String
driverName) {
return this;
}
+ public JdbcConnectionOptionsBuilder withProperties(Properties
properties) {
Review Comment:
@RocMarshal I would say the easiest way, eliminating the method.
If someone has a properties, they can do:
`properties.forEach((key, value) -> builder.withProperty(key, value));`
Under the hood, the `properties.putAll` is what it does.
I always prefer to keep it simple..
If we have to explain, document or add something to explain what is being
done, we are doing it 'wrong'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
