echauchot commented on code in PR #28:
URL:
https://github.com/apache/flink-connector-cassandra/pull/28#discussion_r1574680771
##########
.github/workflows/weekly.yml:
##########
@@ -22,36 +22,24 @@ on:
- cron: "0 0 * * 0"
workflow_dispatch:
jobs:
- # tests that current connector iteration does not break compatibility with
last 2 minor released Flink versions
- non-main-version:
+ compile_and_test:
if: github.repository_owner == 'apache'
+ strategy:
+ matrix:
+ flink_branches: [{
Review Comment:
It is true that all the PRs are tested against last 2 Flink versions but
don't you think that the weekly workflow should also test against these
versions and not only the snapshots ?
##########
.github/workflows/weekly.yml:
##########
@@ -22,36 +22,24 @@ on:
- cron: "0 0 * * 0"
workflow_dispatch:
jobs:
- # tests that current connector iteration does not break compatibility with
last 2 minor released Flink versions
- non-main-version:
+ compile_and_test:
if: github.repository_owner == 'apache'
+ strategy:
+ matrix:
+ flink_branches: [{
+ flink: 1.18-SNAPSHOT,
+ branch: main
+ }, {
+ flink: 1.19-SNAPSHOT,
+ branch: main
+ }, {
+ flink: 1.20-SNAPSHOT,
+ branch: main
+ }]
uses: apache/flink-connector-shared-utils/.github/workflows/ci.yml@ci_utils
with:
- flink_version: 1.17.2
- connector_branch: main
- skip_archunit_tests: true
Review Comment:
Cool that we no more need to test against 1.17.2 and skip the archunit tests
!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
