reswqa commented on PR #24683: URL: https://github.com/apache/flink/pull/24683#issuecomment-2073972675
> > Is TPC-DS performance no longer regression after the fix? > > @reswqa The regression still exists because we replace the HashBufferAccumulator with the SortBufferAccumulator when the decoupling is enabled and the parallelism is less than 512, but this PR reduces the regression. According to the previous discussion, the regression is acceptable if the feature is enabled. Ah, I see. Let's keep improving it then :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
