masteryhx commented on code in PR #24682: URL: https://github.com/apache/flink/pull/24682#discussion_r1578772481
########## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStResourceContainer.java: ########## @@ -0,0 +1,547 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.state.forst; + +import org.apache.flink.annotation.VisibleForTesting; +import org.apache.flink.configuration.ConfigOption; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.ReadableConfig; +import org.apache.flink.core.fs.FileSystem; +import org.apache.flink.runtime.memory.OpaqueMemoryResource; +import org.apache.flink.util.FileUtils; +import org.apache.flink.util.IOUtils; +import org.apache.flink.util.Preconditions; + +import org.rocksdb.BlockBasedTableConfig; +import org.rocksdb.BloomFilter; +import org.rocksdb.Cache; +import org.rocksdb.ColumnFamilyOptions; +import org.rocksdb.DBOptions; +import org.rocksdb.Filter; +import org.rocksdb.FlinkEnv; +import org.rocksdb.IndexType; +import org.rocksdb.PlainTableConfig; +import org.rocksdb.ReadOptions; +import org.rocksdb.Statistics; +import org.rocksdb.TableFormatConfig; +import org.rocksdb.WriteOptions; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import javax.annotation.Nullable; + +import java.io.File; +import java.io.IOException; +import java.net.URI; +import java.nio.file.Files; +import java.nio.file.Path; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collection; + +/** + * The container for ForSt resources, including option factory and shared resource among instances. + * + * <p>This should be the only entrance for ForStStateBackend to get ForSt options, and should be + * properly (and necessarily) closed to prevent resource leak. + */ +public final class ForStResourceContainer implements AutoCloseable { + private static final Logger LOG = LoggerFactory.getLogger(ForStResourceContainer.class); + + private static final String FORST_RELOCATE_LOG_SUFFIX = "_LOG"; + + // the filename length limit is 255 on most operating systems + private static final int INSTANCE_PATH_LENGTH_LIMIT = 255 - FORST_RELOCATE_LOG_SUFFIX.length(); + + private static final String DB_DIR_STRING = "db"; + + @Nullable private final URI remoteBasePath; + + @Nullable private final URI remoteForStPath; + + @Nullable private final File localBasePath; Review Comment: `localBasePath` is the path of keyed state backend while `localForStPath` is the path of ForStDB. It's also consistent with the design of RocksDB -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
