[
https://issues.apache.org/jira/browse/FLINK-35215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840678#comment-17840678
]
Rui Fan commented on FLINK-35215:
---------------------------------
Hi [~q.xu] [~kkrugler] , flink community has a performance regression detector
to detect them, and send the result to Slack channel every day. I noticed these
regression there. If you are interested in it, you can can more details from
here[1][2].
Sometimes the performance regression detector will also send an alert when some
benchmarks fluctuate only occasionally.
But according to my observation, serializerKryo and
serializerKryoWithoutRegistration really have performance regression.(it's not
a big regression.) Let us focus on the java 17 and
serializerKryoWithoutRegistration(I saw java 8 and java11 are similar).
* After April 19, average performance is lower than before April 19.
** Note: let us focus on the average performance instead of single day.
** The reason for single-day performance regression may be caused by
fluctuation.
** In general, the performance will be recovered in a few days if the
performance regression is caused by fluctuation.
** All of them (serializerKryoWithoutRegistration and serializerKryo, java 8,
java11 and java17) don't recovered for now.
* And FLINK-34954 is merged at April 19
* Also, I reverts the FLINK-34954 on my flink fork repo, and try to re-run the
benchmark 3 times.
** The performance is recovered after reverting, that's why I'm sure
FLINK-34954 causes it.
** I will add the result later.
!image-2024-04-25-14-57-55-231.png|width=968,height=365!
!image-2024-04-25-15-00-32-410.png|width=974,height=363!
[1][https://github.com/apache/flink-benchmarks/blob/master/regression_report_v2.py]
[2][https://docs.google.com/document/d/1Bvzvq79Ll5yxd1UtC0YzczgFbZPAgPcN3cI0MjVkIag]
> The performance of serializerKryo and serializerKryoWithoutRegistration are
> regressed
> -------------------------------------------------------------------------------------
>
> Key: FLINK-35215
> URL: https://issues.apache.org/jira/browse/FLINK-35215
> Project: Flink
> Issue Type: Bug
> Components: API / Type Serialization System
> Affects Versions: 1.20.0
> Reporter: Rui Fan
> Priority: Blocker
> Labels: pull-request-available
> Attachments: image-2024-04-25-14-57-55-231.png,
> image-2024-04-25-15-00-32-410.png
>
>
> The performance of serializerKryo and serializerKryoWithoutRegistration are
> regressed[1][2], I checked recent commits, and found FLINK-34954 changed
> related logic.
>
> [1]
> [http://flink-speed.xyz/timeline/#/?exe=1,6,12&ben=serializerKryo&extr=on&quarts=on&equid=off&env=3&revs=50]
> [2]
> http://flink-speed.xyz/timeline/#/?exe=1,6,12&ben=serializerKryoWithoutRegistration&extr=on&quarts=on&equid=off&env=3&revs=50
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
