SML0127 commented on code in PR #3148:
URL: https://github.com/apache/flink-cdc/pull/3148#discussion_r1560428551
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/MySqlValidator.java:
##########
@@ -50,6 +50,7 @@ public class MySqlValidator implements Validator {
private static final String BINLOG_FORMAT_ROW = "ROW";
private static final String BINLOG_FORMAT_IMAGE_FULL = "FULL";
Review Comment:
@ruanhang1993
How about changing the variable names `BINLOG_FORMAT_ROW`,
`BINLOG_FORMAT_IMAGE_FULL` to `DEFAULT_BINLOG_FORMAT`,
`DEFAULT_BINLOG_ROW_FORMAT`?
```suggestion
private static final String DEFAULT_BINLOG_FORMAT = "ROW";
private static final String DEFAULT_BINLOG_ROW_FORMAT = "FULL";
```
In mysql 8, default values for the `binlog_format` and `binlog_row_image`
options are `ROW` and `full`, respectively
-
https://dev.mysql.com/doc/refman/8.0/en/replication-options-binary-log.html#sysvar_binlog_format
-
https://dev.mysql.com/doc/refman/8.0/en/replication-options-binary-log.html#sysvar_binlog_row_image
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
