Jiabao-Sun commented on code in PR #24723:
URL: https://github.com/apache/flink/pull/24723#discussion_r1580689343
##########
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterQueryableStateTest.java:
##########
@@ -96,17 +89,17 @@ public class JobMasterQueryableStateTest extends TestLogger
{
JOB_GRAPH.setJobType(JobType.STREAMING);
}
- @BeforeClass
+ @BeforeAll
public static void setupClass() {
rpcService = new TestingRpcService();
}
- @After
+ @AfterEach
Review Comment:
minor: public void teardown() can be package default.
##########
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterQueryableStateTest.java:
##########
@@ -96,17 +89,17 @@ public class JobMasterQueryableStateTest extends TestLogger
{
JOB_GRAPH.setJobType(JobType.STREAMING);
}
- @BeforeClass
+ @BeforeAll
public static void setupClass() {
rpcService = new TestingRpcService();
}
- @After
+ @AfterEach
public void teardown() throws Exception {
rpcService.clearGateways();
}
- @AfterClass
+ @AfterAll
Review Comment:
minor: public static void teardownClass() can be package default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
