ferenc-csaky commented on code in PR #22789:
URL: https://github.com/apache/flink/pull/22789#discussion_r1581270742
##########
flink-filesystems/flink-gs-fs-hadoop/src/test/java/org/apache/flink/fs/gs/writer/GSRecoverableFsDataOutputStreamTest.java:
##########
@@ -133,57 +131,57 @@ public void before() {
}
}
- @Test
+ @TestTemplate
public void emptyStreamShouldHaveProperPositionAndComponentObjectCount() {
if (empty) {
- assertEquals(0, position);
- assertEquals(0, componentObjectCount);
+ assertThat(position).isZero();
+ assertThat(componentObjectCount).isOne();
Review Comment:
This should be `.isZero()`, and causes the Azure fail. Missed that in my
prev comment. Pls. fix this, if tests are green, then LGTM :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
