caicancai commented on code in PR #116:
URL:
https://github.com/apache/flink-connector-jdbc/pull/116#discussion_r1581771380
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalog.java:
##########
@@ -77,17 +81,42 @@ public JdbcCatalog(
String pwd,
String baseUrl,
String compatibleMode) {
- super(userClassLoader, catalogName, defaultDatabase, username, pwd,
baseUrl);
+ this(
+ userClassLoader,
+ catalogName,
+ defaultDatabase,
+ baseUrl,
+ compatibleMode,
+ getBriefAuthProperties(username, pwd));
+ }
+
+ /**
+ * Creates a JdbcCatalog.
Review Comment:
I mean why the comment is Creates a JdbcCatalog, not Create a JdbcCatalog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
