slankka opened a new pull request, #24733: URL: https://github.com/apache/flink/pull/24733
…se temporary flinkConfigFile treated as remote file. also fix [FLINK-33424] ## What is the purpose of the change If user set fs.default-scheme to hdfs://namenode or s3://any, it will cause /tmp/flink-confxxxx FileNotFoundException. Fix [FLINK-29797](https://issues.apache.org/jira/browse/FLINK-29797) also fix [FLINK-33424](https://issues.apache.org/jira/browse/FLINK-33424) ## Brief change log It is obvious that FileSystem will create a DistributedFileSystem while fs.default-scheme **NOT** set to file://. ### Before change There is no big diffierence between "job.graph" and flink conf file for registerSingleLocalResource except that `tmpJobGraphFile.toURI()` and `tmpConfigurationFile.getAbsolutePath()` ### After change `tmpConfigurationFile.toURI()` will return correct path with `file://` scheme, so if won't causing registerSingleLocalResource treating it as remote files. ## Verifying this change Please make sure both new and modified tests in this PR follow [the conventions for tests defined in our code quality guide](https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#7-testing). *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (100MB)* - *Extended integration test for recovery after master (JobManager) failure* - *Added test that validates that TaskInfo is transferred only once across recoveries* - *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): ( no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no) - The serializers: ( no ) - The runtime per-record code paths (performance sensitive): ( no ) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no) - The S3 file system connector: ( no ) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
